[Webkit-unassigned] [Bug 66030] [Chromium] New windows opened in javascript are named "_blank"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66030


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103583|review?                     |review-
               Flag|                            |




--- Comment #3 from Nate Chapin <japhet at chromium.org>  2011-08-11 16:37:01 PST ---
(From update of attachment 103583)
View in context: https://bugs.webkit.org/attachment.cgi?id=103583&action=review

> Source/WebCore/ChangeLog:12
> +
> +        No new tests because this bug occurs only in Chromium.
> +

Please include a test if at all possible.  Even port-specific bugs typically receive a new layout test, since other ports might regress this behavior at some point :)

> Source/WebCore/loader/FrameLoader.cpp:3265
> +    if (request.frameName() == "_blank")
> +        requestWithReferrer.setFrameName("");

This code isn't chromium-specific, so it seems odd that we're fixing this bug here.  How do the other ports avoid reaching this point with frame mame of "_blank"?  Is this a v8/jsc difference?

It's possible this is the right place to fix the bug, but it would be good to understand what chromium is doing differently before committing to this solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.