[Webkit-unassigned] [Bug 62168] error: converting 'false' to pointer type when compiling with gcc-4.6.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62168





--- Comment #5 from asharif.tools at gmail.com  2011-08-11 16:33:07 PST ---
(From update of attachment 103692)
View in context: https://bugs.webkit.org/attachment.cgi?id=103692&action=review

>> Source/WebCore/dom/Element.cpp:1100
>> +    bool hasParentStyle = parentNodeForRenderingAndStyle() ? (bool) parentNodeForRenderingAndStyle()->renderStyle() : false;
> 
> WebKit usually uses c++ style casts, not c-style casts:
> 
> static_cast<bool>(...)

What do you think between:

bool hasParentStyle = parentNodeForRenderingAndStyle() ? (parentNodeForRenderingAndStyle()->renderStyle() ? true : false) : false;

and

bool hasParentStyle = parentNodeForRenderingAndStyle() ? static_cast<bool>(parentNodeForRenderingAndStyle()->renderStyle()) : false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.