[Webkit-unassigned] [Bug 65627] [CSSRegions]RenderFlowThread should display its content using RenderRegion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65627


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |hyatt at apple.com
                   |kit.org                     |
     Ever Confirmed|0                           |1
 Attachment #102797|0                           |1
        is obsolete|                            |




--- Comment #7 from Dave Hyatt <hyatt at apple.com>  2011-08-11 15:01:51 PST ---
Created an attachment (id=103680)
 --> (https://bugs.webkit.org/attachment.cgi?id=103680&action=review)
Patch (work in progress)

This patch improves upon the original posted one. Things that I changed include:

(1) Fixed a broken test case that said content:from instead of the right syntax.
(2) Added test cases for other writing modes.
(3) Fixed RenderFlowThread's style to inherit from RenderView and to properly update when RenderView's style changed, so that things like the zoom factor and writing mode would be honored in the flow thread.
(4) Rewrote all of the layout functions in RenderFlowThread and painting functions to be writing-mode-aware.
(5) Added new test cases for vertical writing modes.
(6) Fixed some asserts in RenderFlowThread by making sure RenderRegion claims to be replaced.

There's still a problem that I can see with RenderRegions in that you can construct a situation where a RenderFlowThread gets a layout before a RenderRegion does if that RenderRegion goes into the RenderView's positioned objects list after the RenderFlowThread. We will eventually need to customize RenderView's layout I think to make sure that RenderFlowThreads get a layout after the regions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.