[Webkit-unassigned] [Bug 66040] REGRESSION: nrwt does not use the right fallback sequence for platform-specific tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 11 13:24:22 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=66040





--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2011-08-11 13:24:23 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > The SL expected result for LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html would be in LayoutTests/platform/mac-snow-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt (to differentiate from a test at LayoutTests/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html).
> > 
> > Maybe ORWT doesn't work that way?
> 
> ORWT assumes the expected result be in  LayoutTests/platform/mac-snow-leopard/fast/text/international/ instead of LayoutTests/platform/mac-snow-leopard/platform/mac/fast/text/international/

That sounds broken to me. I agree with Tony.

To further complicate things, I'll note that there is also a LayoutTests/platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html file itself.

I.e., there are platform-specific tests for both mac and mac-sl with the same "generic" name :(. In theory, the platform/mac-snowleopard/f/t/i/G-P-v-m-a-expected.txt file could be interpreted as the "generic" result for that test, or be the platform-specific result for the generic f/t/i test (if it existed).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list