[Webkit-unassigned] [Bug 65965] Implement internals.computedStyleIncludingVisitedInfo()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65965


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103453|review?                     |review-
               Flag|                            |




--- Comment #7 from MORITA Hajime <morrita at google.com>  2011-08-11 00:00:33 PST ---
(From update of attachment 103453)
View in context: https://bugs.webkit.org/attachment.cgi?id=103453&action=review

> ChangeLog:8
> +        - Implemented internals.computedStyleIncludingVisitedInfo(), which can be used by all platforms.

This should be at Source/WebCore/ChangeLog

> ChangeLog:9
> +        - Replaced layoutTestController.computedStyleIncludingVisitedInfo() in tests

This should be at LayoutTests/ChangeLog

> ChangeLog:12
> +        platform-dependent codes.

This should be at each of Source/WebKit/*/ChangeLog

> LayoutTests/ChangeLog:2
> +

Ditto.

> LayoutTests/fast/history/multiple-classes-visited.html:11
> +    var firstStyle = window.internals.computedStyleIncludingVisitedInfo(document.getElementById('one'));

Need to check window.internals to make the test runnable outside DRT.

> LayoutTests/fast/history/nested-visited-test.html:-17
> -    if (window.layoutTestController) {

Need to check window.internals to make the test runnable outside DRT.

> LayoutTests/fast/history/nested-visited-test.html:-50
> -<script>

Don't touch unrelated code if possible.

> LayoutTests/fast/history/self-is-visited.html:-11
> -    if (window.layoutTestController) {

Ditto.

> LayoutTests/fast/history/sibling-visited-test.html:-11
> -    if (window.layoutTestController) {

Ditto.

> LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:-13
> -    if (window.layoutTestController) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.