[Webkit-unassigned] [Bug 65835] Need a way to selectively use hixie-76 for websocket connections depending on destination and/or origin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 22:11:42 PDT 2011


--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2011-08-10 22:11:42 PST ---
(From update of attachment 103506)
View in context: https://bugs.webkit.org/attachment.cgi?id=103506&action=review

I'll make a review pass, but as this seems to not be landing on trunk, I'll leave it up to someone from Chromium land to give final review.

1. Normally, no patches can be landed without a ChangeLog: <http://www.webkit.org/coding/contributing.html>.
2. It's unclear to me if you could hardcode for the branch.
3. I think that the patch has a wrong root (it should be above Source).

> WebCore/page/Settings.h:445
> +        void addHixie76WebSocketProtocolException(KURL url);

Should be "const KURL&", and argument should be unnamed, as it doesn't add any information.

> WebCore/page/Settings.h:447
> +        bool useHixie76WebSocketProtocol(KURL url);


> WebCore/page/Settings.h:575
> +        HashMap<String, bool> m_hixie76WebSocketProtocolExceptionList;

Why not HashSet?

> WebCore/page/Settings.cpp:802
> +    url.setPath(String());
> +    url.setQuery(String());
> +    url.setUser(String());
> +    url.setPass(String());
> +    url.removeFragmentIdentifier();

Perhaps you want SecurityOrigin(url).toString()? Not sure - this kind of exception is not pretty either way.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list