[Webkit-unassigned] [Bug 65564] Support for multiple <link rel="icon"> favicon elements.

Wed Aug 10 17:05:49 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65564

--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-08-10 17:05:49 PST ---
(From update of attachment 103559)
View in context: https://bugs.webkit.org/attachment.cgi?id=103559&action=review

> Source/WebCore/html/HTMLLinkElement.cpp:241
> +      document()->page()->chrome()->registerFaviconSource(
> +          getAttribute(hrefAttr), getAttribute(sizesAttr), getAttribute(typeAttr));

Bad indent.  What if page is null?  getAttribute -> fastGetAttribute

> Source/WebKit/chromium/public/WebViewClient.h:319
> +    virtual void registerFaviconSource(const WebString& url,
> +                                        const WebString& sizes,
> +                                        const WebString& mediaType) { }

Bad indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.