[Webkit-unassigned] [Bug 65307] Document markers layout issue when highlithing text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 10 06:51:03 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65307


Kamil Blank <k.blank at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |47237




--- Comment #6 from Kamil Blank <k.blank at samsung.com>  2011-08-10 06:51:02 PST ---
I missed || operator in the 2nd solution. Should be:

2) To add !prevRootBox checking as it was before r71435
diff --git a/Source/WebCore/rendering/RootInlineBox.cpp b/Source/WebCore/rendering/RootInlineBox.cpp
index ecfaaf5..8ad4454 100644
--- a/Source/WebCore/rendering/RootInlineBox.cpp
+++ b/Source/WebCore/rendering/RootInlineBox.cpp
@@ -403,7 +403,7 @@ LayoutUnit RootInlineBox::selectionTop() const
     if (m_hasAnnotationsBefore)
         selectionTop -= !renderer()->style()->isFlippedLinesWritingMode() ? computeOverAnnotationAdjustment(m_lineTop) : computeUnderAnnotationAdjustment(m_lineTop);

-    if (renderer()->style()->isFlippedLinesWritingMode())
+    if (renderer()->style()->isFlippedLinesWritingMode() || !prevRootBox())
         return selectionTop;

     LayoutUnit prevBottom = prevRootBox() ? prevRootBox()->selectionBottom() : block()->borderBefore() + block()->paddingBefore();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list