[Webkit-unassigned] [Bug 58443] [GTK] Support the file system API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58443


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-08-09 19:15:38 PST ---
Attachment 102035 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/filesystem/script-tests/f..." exit_code: 1

Source/WebCore/platform/gtk/AsyncFileWriterGtk.h:8:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/gtk/AsyncFileWriterGtk.cpp:15:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/gtk/AsyncFileWriterGtk.cpp:44:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/platform/gtk/AsyncFileWriterGtk.cpp:49:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/gtk/AsyncFileWriterGtk.cpp:53:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/gtk/AsyncFileSystemCallbacksGtk.cpp:11:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/gtk/AsyncFileSystemCallbacksGtk.h:14:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/gtk/AsyncFileSystemCallbacksGtk.h:32:  The parameter name "writer" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/gtk/AsyncFileSystemGtk.h:32:  The parameter name "client" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/gtk/AsyncFileSystemTaskControllerGtk.cpp:22:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/platform/gtk/AsyncFileSystemTaskControllerGtk.cpp:77:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/gtk/AsyncFileSystemTaskControllerGtk.cpp:106:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/gtk/AsyncFileWriterClientGtk.h:8:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/gtk/AsyncFileSystemGtk.cpp:20:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/gtk/AsyncFileSystemTaskControllerGtk.h:16:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/gtk/AsyncFileSystemTaskControllerGtk.h:28:  The parameter name "taskMode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 16 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.