[Webkit-unassigned] [Bug 65931] New: Leaks bot shows python logging prefixes as part of summary display

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65931

           Summary: Leaks bot shows python logging prefixes as part of
                    summary display
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: aroben at apple.com, abarth at webkit.org,
                    wsiegrist at apple.com


Leaks bot shows python logging prefixes as part of summary display

Right now the summary line looks like this:
#18494    Failed 2011-08-09 11:05:43,602 34458 mac.py:275 info leaks found for a total of 150,368 bytes! 2011-08-09 11:05:43,602 34458 mac.py:276 info 1 unique leaks found! 4 failures 1 flakes run-api-tests

When ORWT looked like this:
Failed 1400 total leaks found! 25 test cases (<1%) had incorrect layout 1 test case (<1%) crashed run-api-tests

After this patch it will look like:
#18494    Failed leaks found for a total of 150,368 bytes! 1 unique leaks found! 4 failures 1 flakes run-api-tests

Which isn't perfect, but much better than before.


In writing this change, I was sure I would make a typo or two, so I had to invent a way to test master.cfg changes.

That turned out to be ridiculously involved, as loading master.cfg not only required a buildbot install (I tried mocking it out at first, but that didn't work), but also required the ability to load/execute python files which have dots in their names and do not end in .py!

It's unclear if we really wanted to add buildbot to autoinstalled.  However normal webkitpy users won't notice any change, only ones running mastercfg_unittest.py will ever cause buildbot to autoinstall.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.