[Webkit-unassigned] [Bug 65908] New: Remove the temporary workaround added by http://trac.webkit.org/changeset/51338

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65908

           Summary: Remove the temporary workaround added by
                    http://trac.webkit.org/changeset/51338
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: marja at chromium.org
                CC: abarth at webkit.org, jochen at chromium.org


SecurityOrigin for a file URL returns "file://", and SecurityOrigin::createFromString("file://") creates a unique (null) security origin (because "file://" is first canonicalized to "file:///" and that is a directory). This means the conversion SecurityOrigin -> string -> SecurityOrigin doens't give back the same SecurityOrigin in case of file URLs.

WebStorageNamespaceImpl::createStorageArea contains a workaround which changes the string "file://" into "file:///a" before giving it to SecurityOrigin::createFromString.

If SecurityOrigin::m_enforceFilePathSeparation is true, then SecurityOrigin::toString() returns "null" for file URLs, and this problem does not exist, and the workaround code is not ran.

This bug is for trying out what breaks if the workaround is removed. I'll submit a patch which just removes it, to see whether there are any tests that rely on the workaround code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.