[Webkit-unassigned] [Bug 63013] [EFL] Page Cache was not Enabled(Enable Page Cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63013





--- Comment #57 from DongJae KIM <dongjae1.kim at samsung.com>  2011-08-08 21:09:59 PST ---
(In reply to comment #56)
> (From update of attachment 103315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103315&action=review
> 
> > Source/WebKit/efl/ChangeLog:22
> > +        (ewk_view_cached_page_restore): Added. adjust view size for restored cached page.
> > +
> > +
> 
> too many empty lines.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:-1459
> > -    if (sd->frame->view())
> > -        return;
> > -
> 
> how is this related? Could you explain?
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:3664
> > +* Restore cached page contents size.
> 
> RestoreS
> 
> > Tools/ChangeLog:10
> > +        Zoom range value must be setted before zoom set, but not in EWebLauncher.
> > +
> > +
> 
> too many empty lines.

Thanks, I will remove empty lines.

> > Source/WebKit/efl/ewk/ewk_frame.cpp:-1459
> > -    if (sd->frame->view())
> > -        return;
> > -
>
EFL Port, FrameView was created, it will be re-use other page, but I think FrameView will be create always when use go to new page, isn't it?

when user add 4th cached page, first cached page will be destroy. 
then frame was released and has null reference assert.

so sd->frame->view() was create always.

test case ::
1. add 3 cached page
2. add one more cached page
3. scroll page
4. assert 


Program received signal SIGSEGV, Segmentation fault.
0x00b671ed in WebCore::EventHandler::setFrameWasScrolledByUser (this=0x4f0)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/page/EventHandler.cpp:2997
2997        FrameView* v = m_frame->view();
(gdb) bt
#0  0x00b671ed in WebCore::EventHandler::setFrameWasScrolledByUser (this=0x4f0)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/page/EventHandler.cpp:2997
#1  0x00b6714d in WebCore::EventHandler::sendScrollEvent (this=0x4f0)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/page/EventHandler.cpp:2990
#2  0x00b7af83 in WebCore::FrameView::scrollPositionChanged (this=0x80b98e0)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/page/FrameView.cpp:1468
#3  0x00b7d3ff in WebCore::FrameView::scrollTo (this=0x80b98e0, newOffset=...)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/page/FrameView.cpp:2110
#4  0x00bd65a7 in WebCore::ScrollView::setScrollOffset (this=0x80b98e0, offset=...)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/platform/ScrollView.cpp:351
#5  0x00bd2592 in WebCore::ScrollableArea::setScrollOffsetFromAnimation (this=0x80b990c, offset=...)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/platform/ScrollableArea.cpp:133
#6  0x0127e999 in WebCore::ScrollAnimator::notityPositionChanged (this=0x80935e0)
    at /home/dongjae/Projects/WebKit_EFL/Source/WebCore/platform/ScrollAnimator.cpp:129
#7  0x0127e4a9 in WebCore::ScrollAnimator::scroll (this=0x80935e0, orientation=WebCore::VerticalScrollbar, step=1, multiplier=40)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.