[Webkit-unassigned] [Bug 65707] Chromium Mac: Enable rubber banding when scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65707





--- Comment #31 from Nico Weber <thakis at chromium.org>  2011-08-08 18:51:26 PST ---
(From update of attachment 103275)
View in context: https://bugs.webkit.org/attachment.cgi?id=103275&action=review

>>>> Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:37
>>>> +#if !defined(MAC_OS_X_VERSION_10_7) || (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7)
>>> 
>>> Shouldn't this be BUILDING_ON_LEOPARD, BUILDING_ON_SNOW_LEOPARD, et al. as defined in Platform.h?
>> 
>> I think we did that back when 10.7 wasn't out yet. Now that 10.7 is out it's probably better to check for that explicitly.
> 
> I'm not sure what those are supposed to mean, but if I read them literally, then the answer is no.
> 
> The #ifdef should be based on which SDK is being targeted, rather than what system it's being built on.
> 
> For example, the patch failed to build on "Webkit Mac10.6" bot, but actually it failed because that bot was targeting the 10.5 SDK.
> 
> So assuming "BUILDING_ON_*" refers to the OS of the system doing the compile, then those macros are not appropriate...

The BUILDING_ON_* macros are defined here: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/JavaScriptCore/wtf/Platform.h&exact_package=chromium&q=TARGETING_LEOPARD&type=cs&l=390

I think this needs to be 

#if BUILDING_ON_LEOPARD || BUILDING_ON_SNOW_LEOPARD

here and

BUILDING_ON_LEOPARD

below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.