[Webkit-unassigned] [Bug 63013] [EFL] Page Cache was not Enabled(Enable Page Cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63013





--- Comment #54 from DongJae KIM <dongjae1.kim at samsung.com>  2011-08-08 16:27:32 PST ---
(In reply to comment #53)
> (From update of attachment 101431 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101431&action=review
> 
> Needs one more interaction for clearance.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:4595
> > + * Restore cached page contents size.
> > + * 
> > + * This method must be called before WebCore::FrameView::layout().
> 
> How does the code ensure that? It is too error-prone, imo.
> 
> > Tools/ChangeLog:10
> > +        When view port changed, zoom level was set. ewk_view_zoom_set() check zoom range
> > +        but zoom range value was old one.
> > +        So, I changed setting sequence.
> 
> typo: checkS*
> 
> Not sure if I understood this sentence.

Thanks your comment.

> > Source/WebKit/efl/ewk/ewk_view.cpp:4595
> > + * Restore cached page contents size.
> > + * 
> > + * This method must be called before WebCore::FrameView::layout().
> 
> How does the code ensure that? It is too error-prone, imo.

:: It is must be called before cached page restore. I will be change this comment more clearly.

> > +        When view port changed, zoom level was set. ewk_view_zoom_set() check zoom range
> > +        but zoom range value was old one.
> > +        So, I changed setting sequence.
> 
> typo: checkS*
> 
> Not sure if I understood this sentence.

Currently, EWebLaunch browser view port change function has some bugs. 
Zoom range must be setted before zoom set, but not. so I changed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.