[Webkit-unassigned] [Bug 65399] StackBounds checker fails on custom stack implementations (typically in a coroutine setting)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65399


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102539|review?                     |review-
               Flag|                            |




--- Comment #9 from Geoffrey Garen <ggaren at apple.com>  2011-08-08 16:11:53 PST ---
(From update of attachment 102539)
View in context: https://bugs.webkit.org/attachment.cgi?id=102539&action=review

> Source/JavaScriptCore/API/JSContextRef.cpp:67
> +void JSSetStackBounds(JSContextGroupRef group, void* origin, void* bound)

Our namespacing convention calls for "JSContextGroupSetStackBounds".

> Source/JavaScriptCore/runtime/JSGlobalData.cpp:210
>          m_stack = wtfThreadData().stack();
> +    else
> +        m_stack = new StackBounds();

This doesn't seem right. For globalDataType != Default, m_stack gets set to "new StackBounds()", but stack() returns wtfThreadData().stack().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.