[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 13:53:07 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65834





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2011-08-08 13:53:07 PST ---
We don't have tree fallback paths now, I doubt we'll easily be able to get rid of them, and changing the teset expectations shouldn't change the fallback paths, regardless (they're different concepts).

[ Unless of course we fundamentally want to change some aspect of how test expectations work ].

That said, the only way to currently share expectations is to share the same expectations.txt file.

Given that Chromium ports currently use the expectations file to track that the expectation is "expected to fail" and hence are using the expectations as "correctness" tests, and the other ports check in "failing" expectations and hence use the expectations as "regression" tests, we almost certainly don't want to share Chromium- and non-Chromium expectations.txt files. Besides, the Chromium file is is already way too big and churns too often.

It's not clear to me that we need more than a "generic" set of expectations that applies to all ports in addition to the the "port-specific" expectations. I would be tempted to prototype that first and see if that got us what we wanted. 

But, it's not clear to me what we "want", either. 

My proposal would be that we (a) change Chromium to match the other port's behavior and view tests as regression tests, not correctness tests (i.e., check in revised platform-specific expectations) and then (b) see if we can get away with either a single file for all ports or a generic + port-specific file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list