[Webkit-unassigned] [Bug 64994] Add the ability to search the AccessibilityObject cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64994





--- Comment #28 from chris fleizach <cfleizach at apple.com>  2011-08-08 09:35:10 PST ---
(In reply to comment #27)
> (In reply to comment #26)
> > (From update of attachment 103194 [details] [details])
> > can't you just use 
> > AccessibilityObject* obj = const_cast<this>;
> 
> const casting an accessibilityTable to an accessibilityObject is not allowed.
> 

I suppose you could do this, but i don't know if it's any easier.

AccessibilityObject* obj = dynamic_cast<AccessibilityObject*>(const_cast<AccessibilityTable*>(this));

At the least, you should be able to use get() instead of getOrCreate() since you know the object exists

axObjectCache()->get(m_renderer)

> > 
> > also is there a layout test that needs to be updated to reflect this change?
> 
> The existing layout test for tables will continue to work. This change just makes the level values reported more consistent with other level values. For example, the search-predicate.html layout test currently sees that two level 0 tables are at the same level. After this change it will see that two level 1 tables are at the same level. Further, level 0 will be correctly reserved for objects which aren't tables at all. This is the behavior displayed when one calls headingLevel() on a non-heading.

Sounds like we should probably add a new layout test to ensure that we get the right levels when we ask a table for it's table level.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.