[Webkit-unassigned] [Bug 42330] WebKitTestRunner needs layoutTestController.waitForPolicyDelegate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 8 08:51:11 PDT 2011


--- Comment #7 from Andras Becsi <abecsi at webkit.org>  2011-08-08 08:51:11 PST ---
(From update of attachment 103249)
View in context: https://bugs.webkit.org/attachment.cgi?id=103249&action=review

Seems ok now, just a few comments yet:

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:134
> +void LayoutTestController::setCustomPolicyDelegate(bool enabled, bool permissive)

This at least needs a comment, like "FIXME: Needs a full implementation see https://bugs.webkit.org/show_bug.cgi?id=42546"

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:54
> +    static bool policyDelegateEnabled;
> +    static bool policyDelegatePermissive;

These do not need to be static, do they? They could simply be private members, with inline getter methods.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list