[Webkit-unassigned] [Bug 64297] Web Inspector:

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103018|review?                     |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2011-08-08 04:43:39 PST ---
(From update of attachment 103018)
View in context: https://bugs.webkit.org/attachment.cgi?id=103018&action=review

Nice idea, it would be nice to have the inspector back.
This should be implemented through private C++ apis though, not via the C APIs. Talk with Alexis to see what his plans are for private APIs.

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:54
> +    QDesktopWebView(WKContextRef, WKPageGroupRef);
> +    WKPageRef pageRef() const;
> +

This should really not be public. Do not forget this Class is in the public API.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:85
> +    m_view->setWindowTitle(QString::fromAscii("Web Inspector - ")+QString::fromAscii(url.utf8().data()));

QString::fromAscii() is never a good idea in the library. The first should probably be tr().
The second is definitely wrong. There is constructor for that.
You need to add spaces on both side of the + sign.

> Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp:105
> +    return ("qrc:/webkit/inspector/inspector.html");

Not sure Whey there are parentesis here :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.