[Webkit-unassigned] [Bug 65088] Intel Compiler on windows fails to build

Sat Aug 6 04:36:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65088

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103108|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #19 from Benjamin Poulain <benjamin at webkit.org>  2011-08-06 04:36:39 PST ---
(From update of attachment 103108)
View in context: https://bugs.webkit.org/attachment.cgi?id=103108&action=review

> ChangeLog:9
> +        Disable warning that uses different number in Intel compiler than Visual Studio
> +

Before landing, improve the changelog mentioning which warning is disabled.

> Source/JavaScriptCore/wtf/NullPtr.h:38
> -#if __has_feature(cxx_nullptr) || (GCC_VERSION_AT_LEAST(4, 6, 0) && defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && _MSC_VER >= 1600)
> +#if __has_feature(cxx_nullptr) || (GCC_VERSION_AT_LEAST(4, 6, 0) && defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) && _MSC_VER >= 1600 && !COMPILER(INTEL))

My bad, first time I did not notice the new test was inside the parenthesis. This is ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.