[Webkit-unassigned] [Bug 65645] Scroll animator changes to nail the framerate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65645


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103111|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #16 from James Robinson <jamesr at chromium.org>  2011-08-05 19:18:43 PST ---
(From update of attachment 103111)
View in context: https://bugs.webkit.org/attachment.cgi?id=103111&action=review

R=me, one nit.  You don't have to upload another patch for review, just upload a new patch that has "Reviewed by James Robinson." in the ChangeLogs instead of NOBODY (OOPS!) and mark the patch cq? but not review? and any committer can flag it for review. I've come down with some sort of illness so I might not be able to get back to this soon.

> Source/WebCore/platform/ScrollAnimatorNone.cpp:318
> +    bool result = data.updateDataFromParameters(orientation, step, multiplier, scrollableSize, WTF::monotonicallyIncreasingTime(), &parameters);

nitpick: "result" is not very illuminating.  what does it mean when updateDataFromParameters() returns false?  was there some problem with the input parameters, or internal error in the calculations? did the scroll happen or not?  I'd suggest renaming this variable to describe what it means.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.