[Webkit-unassigned] [Bug 51099] [Qt] QWebPagePrivate::inputMethodEvent has problem when compositing Korean

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51099





--- Comment #17 from Robert Hogan <robert at webkit.org>  2011-08-05 17:41:43 PST ---
(From update of attachment 95382)
View in context: https://bugs.webkit.org/attachment.cgi?id=95382&action=review

> Source/WebKit/qt/Api/qwebpage.cpp:1133
>              editor->confirmComposition(ev->commitString());
>          else
>              editor->insertText(ev->commitString(), 0);
> +        frame->selection()->setCaretVisible(true);
>      } else if (!hasSelection && !ev->preeditString().isEmpty())
>          editor->setComposition(ev->preeditString(), underlines, 0, 0);
> -    else if (ev->preeditString().isEmpty() && editor->hasComposition())
> +    else if (ev->preeditString().isEmpty() && editor->hasComposition()) {
>          editor->confirmComposition(String());
> +        frame->selection()->setCaretVisible(true);
> +    }
>  

It should be possible to test this in tst_qwebpage. See void tst_QWebFrame::inputFieldFocus() for an example of testing for a blinking caret.

> Source/WebKit/qt/ChangeLog:12
> +        It is nature to composite the text without the caret if Cursor's length is zero.

s/nature/natural

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.