[Webkit-unassigned] [Bug 34753] CSS 2.1: first-line-selector-008.htm test fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34753





--- Comment #13 from Robert Hogan <robert at webkit.org>  2011-08-05 17:26:53 PST ---
(In reply to comment #11)
> (From update of attachment 93615 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93615&action=review
> 
> > Source/WebCore/rendering/InlineTextBox.cpp:189
> > +    const UChar* characters = transformed.characters() + m_start;
> 
> It looks like you should create a static helper function that does this rather than repeat it throughout the code.

Whoops, I meant to comment the quoted line and the line above it, i.e.:

 const String transformed = textRenderer()->getTransformedText(m_firstLine);
 const UChar* characters = transformed.characters() + m_start;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.