[Webkit-unassigned] [Bug 51170] [Qt] The IME composition is strangely affected by another text field

Fri Aug 5 17:08:16 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=51170

Robert Hogan <robert at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robert at webkit.org

--- Comment #11 from Robert Hogan <robert at webkit.org>  2011-08-05 17:08:16 PST ---
(In reply to comment #8)
> I am trying to make some comments here: :)
> The layout tests look great. But the code change is Qt only and tests are cross-platform. So my question is: Will these tests pass for all platforms? If not, you may have to fix other platforms, too. If they do, did you figure out why? I briefly looked the setInputMethodState function in other platforms and didn't see much implementation in it. Then why Qt needs the confirmComposition handling?

I think this may be working for GTK because it confirms the composition in EditorClientGTK::respondToChangedSelection(), and in chromium because it does the same when the text is unmarked.

IME implementations seem so many and varied it looks hard to follow another port's practice. When messing with IME stuff in the past I found it hard to keep one or other of the generic WebKit IME layout tests and the QtWebKit unit tests for QWebPage's inputMethodEvent() from breaking. You should make sure both pass before you land this when someone r+'s it. 

It would be great to have someone fix all the broken input method stuff in QtWebKit so hopefully this is the first of many!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.