[Webkit-unassigned] [Bug 65277] Improve performance of --webkit-visual-word

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 5 15:28:44 PDT 2011


--- Comment #2 from Van Lam <vanlam at google.com>  2011-08-05 15:28:43 PST ---
Created an attachment (id=103122)
 --> (https://bugs.webkit.org/attachment.cgi?id=103122&action=review)
WIP patch, would like some feedback

Detailed description of changes:

- Extracted functionality of findNextWordFromIndex into findNextWordFromIndexConsideringWordBreakPositioningRelativeToWord (this name is WIP) so that it can be parametrized with whether the word break should be logically before or after the word while maintaining existing functionality.

- Added four new search functions to be passed into nextBoundary/previousBoundary to choose where the word break should be. This is what I'd like most feedback on as doing it this way results in some duplicate code. An alternative to adding four new search functions introducing some duplicate code is to add a parameter to each search function; while there is no duplicate code, this would require changing more code (which includes adding parameters that will be unused in search functions endWordBoundary, endSentenceBoundary, and nextSentencePositionBoundary).

- In right/leftWordPositionAcrossBoundary, we never need to collect word breaks within a single box; this is an improvement because previously when moving right in an LTR block or left in an RTL block, word breaks would always be collected; this is significant for cases where runs of text of one directionality are very long.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list