[Webkit-unassigned] [Bug 65790] [QT] Possible Leaks WKRetainPtr<> should Adopt allocated Copy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65790


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org>  2011-08-05 14:20:09 PST ---
I should clarify.

>     WebKit2/UIProcess/API/qt/qweberror.cpp
>     61:    WKRetainPtr<WKStringRef> errorDomainPtr = adoptWK(WKErrorCopyDomain(d->error.get()));
>     80:    WKRetainPtr<WKURLRef> failingURL = adoptWK(WKErrorCopyFailingURL(d->error.get()));

These look good because of the adoptWK(...).

>     WebKit2/UIProcess/qt/qwkhistory.cpp
>     76:    WKRetainPtr<WKStringRef> title = WKBackForwardListItemCopyTitle(d->m_backForwardListItem.get());
>     84:    WKRetainPtr<WKURLRef> url = WKBackForwardListItemCopyURL(d->m_backForwardListItem.get());

These however don't look so good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.