[Webkit-unassigned] [Bug 65723] A few purely stylistic modifications to visible_units.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65723





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-05 11:01:38 PST ---
(From update of attachment 102992)
View in context: https://bugs.webkit.org/attachment.cgi?id=102992&action=review

>> Source/WebCore/editing/visible_units.cpp:1450
>> +        return -1;
> 
> Replacing a name constant with a magic value of -1 does not seem like a style improvement to me.

invalidOffset was supposed to be used only for offsets in inline boxes.  So this was misused here.  We can introduce new const like NotFound instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.