[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60529





--- Comment #48 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-04 16:51:32 PST ---
(In reply to comment #47)
> (In reply to comment #46)
> > Alternatively, can we set isDirectional(true) in FrameSelection's constructor?
> 
> Do you mean VisibleSelection? I think that that would cause the inverse issue on macs; what is presently directional would be non-directional, and vice versa, in this specific case.

No. In FrameSelection::FrameSelection, you can call shouldAlwaysUseDirectionalSelection because you have access to frame there.

So you'd do:

if (shouldAlwaysUseDirectionalSelection(m_frame))
  m_selection.setIsDirectional(true);

(of course, you'd have to move the definition of shouldAlwaysUseDirectionalSelection to the top of the file).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.