[Webkit-unassigned] [Bug 65715] Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65715





--- Comment #4 from Mark Pilgrim <pilgrim at chromium.org>  2011-08-04 13:59:00 PST ---
(In reply to comment #2)
> (From update of attachment 102972 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102972&action=review
> 
> > Source/WebCore/dom/Clipboard.idl:-32
> > -        LegacyDefaultOptionalArguments,
> 
> is RequiresAllArguments still needed for setData ?

Yes. [RequiresAllArguments] is different from [RequiresAllArguments=Raise].

> 
> > Source/WebCore/dom/MediaStreamList.idl:31
> > -        MediaStream item(in [IsIndex] unsigned long index);
> > +        MediaStream item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
> 
> I'm slightly unsure about this one.  The MediaStream stuff is very new, so maybe it doesn't need it?  On the other hand, having all these fake vectors be consistent seems beneficial.
> 
> > Source/WebCore/dom/MediaStreamTrackList.idl:31
> > -        MediaStreamTrack item(in [IsIndex] unsigned long index);
> > +        MediaStreamTrack item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
> 
> This probably isn't needed.

New patch coming up...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.