[Webkit-unassigned] [Bug 65715] Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65715


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102972|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-08-04 13:52:34 PST ---
(From update of attachment 102972)
View in context: https://bugs.webkit.org/attachment.cgi?id=102972&action=review

> Source/WebCore/dom/Clipboard.idl:-32
> -        LegacyDefaultOptionalArguments,

is RequiresAllArguments still needed for setData ?

> Source/WebCore/dom/MediaStreamList.idl:31
> -        MediaStream item(in [IsIndex] unsigned long index);
> +        MediaStream item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);

I'm slightly unsure about this one.  The MediaStream stuff is very new, so maybe it doesn't need it?  On the other hand, having all these fake vectors be consistent seems beneficial.

> Source/WebCore/dom/MediaStreamTrackList.idl:31
> -        MediaStreamTrack item(in [IsIndex] unsigned long index);
> +        MediaStreamTrack item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);

This probably isn't needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.