[Webkit-unassigned] [Bug 65611] Add firstPartyOrigin parameter to WebStorageNamespace::createStorageArea

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65611


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102881|review?                     |review-
               Flag|                            |




--- Comment #11 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-04 10:37:24 PST ---
(From update of attachment 102881)
View in context: https://bugs.webkit.org/attachment.cgi?id=102881&action=review

> Source/WebKit/chromium/public/WebStorageNamespace.h:71
> +    virtual WebStorageArea* createStorageArea(const WebString& origin, const WebString& firstPartyOrigin);

i think it would make sense to switch over to passing WebSecurityOrigin instead of WebString.
it is often better to expose WebSecurityOrigin instead of raw strings.  when createStorageArea
was first created, we probably didn't yet have WebSecurityOrigin or the discipline to pass it
around instead of raw strings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.