[Webkit-unassigned] [Bug 59064] [GTK] Support EGL backend for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59064





--- Comment #17 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2011-08-03 18:02:54 PST ---
(In reply to comment #16)
> (From update of attachment 102630 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102630&action=review
> 
> The common code looks fine to me. I would suggest you similarly split the Gtk GraphicsContext3D implementation files to avoid all of the #if USE(EGL) constructs that have been added there. However, I'd be fine r+'ing this as is. I'll defer to mrobinson in case he wants to re-review, but ping me if you want me to r+ it.
> 
> >>>> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLBase.cpp:35
> >>>> +
> >>> 
> >>> Are you sure the style queue failure is due to the presence of the Qt header, and not due to the name GraphicsContext3D.h (rather than GraphicsContext3DOpenGLBase.h) being used here? If it's being triggered by the latter, you could create a GraphicsContext3DOpenGLBase.h which just includes GraphicsContext3D.h as a workaround.
> >> 
> >> O.K. Let me check it again.
> > 
> > Warning is gone if I move or remove Qt header.
> > Whereas I change the header GraphicsContext3D.h to GraphicsContext3DOpenGLBase.h, warning is still there.
> > Of course, I can move Qt header to avoid style warning in this patch, but I can't convince no problem.
> 
> OK. Thanks for double-checking.
Thanks for kind review! :)

> I would suggest you similarly split the Gtk GraphicsContext3D implementation files to avoid all of the #if USE(EGL) constructs that have been added there.
@mrobinson What do you think about this? Do you think it'd be better to split GraphicsContext3DInternal.cpp & GraphicsContext3DGtk.cpp?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.