[Webkit-unassigned] [Bug 65641] JSC GC heap size improvement breaks build on some platforms due to unused parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65641


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102824|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-08-03 14:37:44 PST ---
(From update of attachment 102824)
View in context: https://bugs.webkit.org/attachment.cgi?id=102824&action=review

> Source/JavaScriptCore/heap/Heap.cpp:51
> +    ASSERT_UNUSED(heapSize, heapSize == LargeHeap || heapSize == SmallHeap);

Using ASSERT_UNUSED with an argument that actually is used might cause problems in the future even if it doesn’t right now. It would be better to structure the ifdefs so the ASSERT_UNUSED is inside the #else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.