[Webkit-unassigned] [Bug 65596] [EFL] Implement dummy IconDatabaseClientEfl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 3 08:21:08 PDT 2011


--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2011-08-03 08:21:08 PST ---
(From update of attachment 102746)
View in context: https://bugs.webkit.org/attachment.cgi?id=102746&action=review

LGTM, just a minor nit.

> Source/WebKit/efl/WebCoreSupport/IconDatabaseClientEfl.cpp:39
> +void IconDatabaseClientEfl::didImportIconURLForPageURL(const String& url)

Unused parameters shouldn't have their names declared.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list