[Webkit-unassigned] [Bug 65616] [GTK] Reorganize header files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 3 06:42:54 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65616
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102777|review? |review-
Flag| |
--- Comment #3 from Martin Robinson <mrobinson at webkit.org> 2011-08-03 06:42:54 PST ---
(From update of attachment 102777)
View in context: https://bugs.webkit.org/attachment.cgi?id=102777&action=review
This patch should probably also add webkitgtk.h to the list of headers skipped by the style bot.
> GNUmakefile.am:44
> +libwebkitgtkincludedir := $(prefix)/include/webkitgtk- at WEBKITGTK_API_VERSION@
libwebkitgtk_include_dir?
> Source/WebKit/gtk/GNUmakefile.am:34
> +# Global header
> +libwebkitgtkinclude_HEADERS += \
> + $(srcdir)/Source/WebKit/gtk/webkitgtk.h
> +
Is 32libwebkitgtkinclude_HEADERS a primary? I don't see it referenced anywhere else. What is the significance of the string "libwebkitgtkinclude". I think this should be next to the other list of headers.
> Source/WebKit/gtk/webkit/webkit.h:21
> +#warning "<webkit/webkit.h> is deprecated, use <webkitgtk.h> instead."
Maybe say "Including <webkit/webkit.h> is deprecated, include <webkitgtk.h> directly instead."
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list