[Webkit-unassigned] [Bug 65319] [GTK] Use GRefPtr for SOUP_TYPE_CONTENT_DECODER in WebKit2.

Wed Aug 3 05:45:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=65319

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org,
                   |                            |svillar at igalia.com

--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-08-03 05:45:09 PST ---
(In reply to comment #2)
> (From update of attachment 102257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review
> 
> > Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65
> > -    soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
> > +    GRefPtr<SoupSessionFeature> decoder = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_DECODER, NULL)));
> > +    soup_session_add_feature(session, decoder.get());
> 
> Why is this an improvement?

By this I mean, why don't we just use soup_session_add_feature_by_type everywhere?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.