[Webkit-unassigned] [Bug 60529] Programmatically set selection should not have direction on Mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 21:24:08 PDT 2011


--- Comment #43 from Ryosuke Niwa <rniwa at webkit.org>  2011-08-02 21:24:07 PST ---
(From update of attachment 102736)
View in context: https://bugs.webkit.org/attachment.cgi?id=102736&action=review

The patch looks much better.  Hopefully most of these rebaselines will go away as you preserve / set isDirectional more.

> Source/WebCore/editing/FrameSelection.cpp:1029
> +

We don't need a blank line here.

> Source/WebCore/editing/FrameSelection.cpp:1030
> +    setSelection(VisibleSelection(pos.deepEquivalent(), m_selection.extent(), pos.affinity(), selectionHasDirection), CloseTyping | ClearTypingStyle | userTriggered);

Huh, CloseTyping | ClearTypingStyle is repeated everywhere (there are two places in FrameSelection.h as well).  Can we define SetSelectionDefaultOptions and use that instead?  That could be a separate patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list