[Webkit-unassigned] [Bug 65592] WebSocket could not handle zero length text frame.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65592





--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-08-02 21:17:16 PST ---
(From update of attachment 102737)
View in context: https://bugs.webkit.org/attachment.cgi?id=102737&action=review

> Source/WebCore/websockets/WebSocketChannel.cpp:560
>                  String message = String::fromUTF8(continuousFrameData.data(), continuousFrameData.size());
> -                if (message.isNull())
> +                if (message.isNull() && continuousFrameData.size())

Can we avoid String::fromUTF8() when continuousFrameData.size() == 0?

> Source/WebCore/websockets/WebSocketChannel.cpp:575
>              String message = String::fromUTF8(frame.payload, frame.payloadLength);
>              skipBuffer(frame.frameEnd - m_buffer);
> -            if (message.isNull())
> +            if (message.isNull() && frame.payloadLength)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.