[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable frames and iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257


Adrienne Walker <enne at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |noam.rosenthal at nokia.com




--- Comment #52 from Adrienne Walker <enne at google.com>  2011-08-02 18:04:34 PST ---
(In reply to comment #50)
> (From update of attachment 100879 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100879&action=review
> 
> > Source/WebCore/page/ChromeClient.h:268
> > +            ScrollableFrameTrigger = 1 << 5,
> 
> Ports other than chromium set m_compositingTriggers = AllTriggers, meaning that they will also get composited iframes. Do we want that?

Grep says this is just the Qt port.  I'll CC noamr to see if ChromeClientQt should be adjusted or if this behavior is ok.

> > Source/WebCore/rendering/RenderLayerCompositor.cpp:1351
> > +bool RenderLayerCompositor::requiresCompositingForScrollableFrame(RenderView* view) const
> 
> Doesn't this method need to be called from requiresCompositingLayer()?  If not, what is it that guarantees that the iframe gets its own backing?

requiresCompositingLayer is a check for if a layer needs to be composited.  This function checks if a view needs to be composited.  It gets a backing via the force compositing mode flag which triggers enableCompositingMode() during updateCompositedLayers(), which in turn calls ensureRootLayer().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.