[Webkit-unassigned] [Bug 65428] dir=auto needs to work on value of input and textarea elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65428


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102705|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-08-02 17:53:45 PST ---
(From update of attachment 102705)
View in context: https://bugs.webkit.org/attachment.cgi?id=102705&action=review

> Source/WebCore/html/HTMLElement.cpp:876
> +    HTMLTextFormControlElement* textElement = toTextFormControl(const_cast<HTMLElement*>(this));
> +    if (textElement) {

Would be elegant to put this definition inside the if so it gets scoped.

> Source/WebCore/html/HTMLElement.cpp:881
> +        return (textDirection == WTF::Unicode::LeftToRight) ? LTR : RTL;

Is the WTF:: needed here?

> Source/WebCore/html/HTMLElement.cpp:888
>          // Skip bdi, script and style elements
> -        if (equalIgnoringCase(node->nodeName(), "bdi") || node->hasTagName(scriptTag) || node->hasTagName(styleTag)) {
> +        if (equalIgnoringCase(node->nodeName(), "bdi") || node->hasTagName(scriptTag) || node->hasTagName(styleTag) 
> +            || (node->isElementNode() && toElement(node)->isTextFormControl())) {

The comment no longer matches the code.

> Source/WebCore/html/HTMLInputElement.cpp:666
> +    // When typing in a input field, childrenChanged is not called, so we need to force the directionality check.

should be "an input field"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.