[Webkit-unassigned] [Bug 65006] Draw rectangular box shadow for elements with border-radius if no corners are visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65006


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102703|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #15 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-08-02 17:11:42 PST ---
(From update of attachment 102703)
View in context: https://bugs.webkit.org/attachment.cgi?id=102703&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1132
> +static bool cornersIntersect(const RoundedRect& border, const LayoutRect& clipRect)

I don't think the name of this function is quite right. It's asking whether any of the rounded corners fall inside the clipRect. You could call it isAnyCornerVisible() or something. Or you could flip the logic around and call it allCornersClippedOut().

> LayoutTests/platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.txt:4
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderBlock {HTML} at (0,0) size 800x600

You should make this a dumpAsText(true). Where are the pixel results? If the pixel result includes a scrollbar, you should refactor the test to avoid this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.