[Webkit-unassigned] [Bug 65569] Remove LegacyDefaultOptionalArguments flag from Console.idl
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 2 15:34:20 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65569
Adam Barth <abarth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102697|review? |review-
Flag| |
--- Comment #2 from Adam Barth <abarth at webkit.org> 2011-08-02 15:34:20 PST ---
(From update of attachment 102697)
View in context: https://bugs.webkit.org/attachment.cgi?id=102697&action=review
> Source/WebCore/page/Console.idl:44
> - [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in boolean condition);
> + [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in [Optional=CallWithDefaultValue] boolean condition);
I suspect this attribute doesn't do anything here either because this function has CustomArgumentHandling.
> Source/WebCore/page/Console.idl:51
> + [Custom] void profile(in [Optional=CallWithDefaultValue] DOMString title);
> + [Custom] void profileEnd(in [Optional=CallWithDefaultValue] DOMString title);
This attribute doesn't do anything for [Custom] bindings. We can omit it.
> Source/WebCore/page/Console.idl:55
> + void time(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title);
> + [CustomArgumentHandling] void timeEnd(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title);
This one might need to stay though. I'm not sure how CustomArgumentHandling works on V8.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list