[Webkit-unassigned] [Bug 65428] dir=auto needs to work on value of input and textarea elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65428





--- Comment #3 from Yael <yael.aharon at nokia.com>  2011-08-02 14:41:59 PST ---
(In reply to comment #2)
> (From update of attachment 102584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102584&action=review
> 
Thank you for the review :)
> > Source/WebCore/html/HTMLElement.cpp:887
> > +        if (equalIgnoringCase(node->nodeName(), "bdi") || node->hasTagName(scriptTag) || node->hasTagName(styleTag) || (node->isElementNode() && toElement(node)->isTextFormControl())) {
> 
> Maybe split into two lines?
> 
ok

> > Source/WebCore/html/HTMLTextAreaElement.cpp:259
> > +    // When typing in a textarea, childrenChanged is not called, so we need to force the directionality check.
> > +    calculateAndAdjustDirectionality();
> 
> Should we also call this in setValue and when "dir" attribute is changed?  e.g. dir attribute is removed and we need to figure out new directionality.
> 
We already handle the case where dir attribute changes in HTMLTextAreaElement, like we handle it for any other HTMLElement so there is no need to explicitly call calculateAndAdjustDirectionality()

> > LayoutTests/fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt:9
> > +PASS document.defaultView.getComputedStyle(el, null).getPropertyValue('border-right-color') is 'rgb(255, 0, 0)'
> 
> This is a very clever way of testing!
thanks :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.