[Webkit-unassigned] [Bug 65564] New: Support for multiple <link rel="icon"> favicon elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65564

           Summary: Support for multiple <link rel="icon"> favicon
                    elements.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: groby at chromium.org
                CC: darin at apple.com, ap at webkit.org, dglazkov at chromium.org,
                    aa at chromium.org


HTML5 supports the idea for multiple favicons - http://www.whatwg.org/specs/web-apps/current-work/multipage/links.html#rel-icon - but WebKit currently only supports three different specific icons (FavIcon, TouchIcon, TouchPrecomposedIcon). Chromium will shortly need that support. (Larger bookmark icons). Bug #37674 was resolved in preparation to this and contains additional info.

I can see two possible ways to implement this:

1) As described in Bug #37674

* collect al* rel-icon links when WebKit does the initial tree traversal - LinkLoader::loadLink is called for each <link rel="icon"> entry.
* WebCore::Document will be extended to contain a list of all icons encountered. (Currently, only keeps track of three predefined ones). Document::setIconURL will track them, and they will be exposed via accessor

2) link element callback on WebCore::Chrome, invoked by HTMLLinkElement constructor

Both methods are backwards-compatible. Existing APIs are not changed, FavIcon selection is not modified, no additional resources will be loaded.

#1 is consistent with the current approach to icons, but requires more code in WebCore. #2 makes it very clear that FavIcon selection is a job outside of WebCore, and has a smaller code footprint.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.