[Webkit-unassigned] [Bug 65556] JSC GC uses dummy cells to avoid having to remember which cells it has already destroyed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 2 13:12:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65556





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2011-08-02 13:12:26 PST ---
(In reply to comment #4)
> (From update of attachment 102685 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102685&action=review
> 
> > Source/JavaScriptCore/heap/MarkedBlock.h:77
> >              FreeCell* next;
> > +            
> > +            void setNoObject()
> > +            {
> > +                *reinterpret_cast<void**>(this) = 0;
> > +            }
> 
> Why this cast void**?  FreeCell doesn't have a vtable pointer, you're simply assigning null to this->next?

I did that to emphasize the fact that I'm setting what-would-have-been-a-vtable to 0.  I suppose a comment would do the same job, so I'll post a fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list