[Webkit-unassigned] [Bug 65200] CSS Regions build bot should archive and upload output files
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 2 07:18:55 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=65200
Adam Roben (:aroben) <aroben at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #102644|review? |review-
Flag| |
--- Comment #9 from Adam Roben (:aroben) <aroben at apple.com> 2011-08-02 07:18:56 PST ---
(From update of attachment 102644)
View in context: https://bugs.webkit.org/attachment.cgi?id=102644&action=review
Just a couple of cosmetic issues this time. Looks great!
> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:262
> "platform": "mac-snowleopard", "configuration": "release", "architectures": ["x86_64"], "features": ["css-regions", "css-exclusions"],
> - "slavenames": ["adobe-mac-slave1"]
> + "upload": true, "slavenames": ["adobe-mac-slave1"]
I'd recommend putting "upload": true on its own line above "slavenames".
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:135
> + extraFeatures=lambda properties:UploadBuiltProduct.determineExtraFeatures(properties))
Missing a space after the colon.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list