[Webkit-unassigned] [Bug 65200] CSS Regions build bot should archive and upload output files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65200





--- Comment #7 from Adam Roben (:aroben) <aroben at apple.com>  2011-08-02 06:05:19 PST ---
(From update of attachment 102233)
View in context: https://bugs.webkit.org/attachment.cgi?id=102233&action=review

>>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:133
>>> +    masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%(extraFeatures)s/%(got_revision)s.zip", extraFeatures=lambda build:UploadBuiltProduct.determineExtraFeatures(build))
>> 
>> I'm surprised the lambda is needed.
> 
> determineExtraFeatures will only be defined after this initialization. I'm new to python, so I might be wrong. The options that I found to be working are:
> a. put the method at the module level 
> b. use the lambda
> c. move the method before masterdest, but I think it looks better to have the properties grouped at the top

The lambda seems OK. But you should rename the parameter to "properties", since what is passed is a Properties instance, not a Build instance.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:140
> +    def determineExtraFeatures(build):

Same comment here about renaming "build" to "properties".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.