[Webkit-unassigned] [Bug 65436] Use threadsafeCopy() API when using Database Directory path variable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 1 16:54:20 PDT 2011


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #102468|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #4 from David Levin <levin at chromium.org>  2011-08-01 16:54:20 PST ---
(From update of attachment 102468)
View in context: https://bugs.webkit.org/attachment.cgi?id=102468&action=review

> Source/WebCore/ChangeLog:8
> +        Use threadsafeCopy() API when using m_databaseDirectoryPath string variable

when the databaseGuard lock hasn't been taken

> Source/WebCore/storage/DatabaseTracker.cpp:105
> +    return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.threadsafeCopy(), "Databases.db");

This one seems good.

> Source/WebCore/storage/DatabaseTracker.cpp:820
> +           SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectoryPath.threadsafeCopy());

This seems unnecessary since the lock m_databaseGuard has been taken.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list