[Webkit-unassigned] [Bug 58013] [Chromium] Needs eventSender.scalePageBy()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58013





--- Comment #9 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-08-01 16:23:06 PST ---
(From update of attachment 102490)
View in context: https://bugs.webkit.org/attachment.cgi?id=102490&action=review

> Source/WebKit/chromium/public/WebView.h:206
> +    // Page scaling --------------------------------------------------------

nit: preserve two new lines above comment.

> Source/WebKit/chromium/public/WebView.h:209
> +    virtual void scalePageBy(float scaleFactor, float x, float y) = 0;

nit: use WebFloatPoint instead of raw "x" and "y"

this method sounds like it is related to setZoomLevel.  how does it differ?
how is it related?  if related, then shouldn't it be in the "Zoom" section?

it is not obvious how zooming differs from scaling.  they sound like synonyms.

> Source/WebKit/chromium/public/WebView.h:211
>      // Media ---------------------------------------------------------------

ditto

> Source/WebKit/chromium/src/WebViewImpl.cpp:1819
> +void WebViewImpl::scalePageBy(float scaleFactor, float x, float y)

nit: please insert new method definitions in the same order as they appear in the header, WebViewImpl.h.

> Source/WebKit/chromium/src/WebViewImpl.h:388
> +    void scalePageBy(float scaleFactor, float x, float y);

nit: please insert new method declarations in the same order as they appear in the interface, WebView.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.