[Webkit-unassigned] [Bug 62175] [GTK] Implement monotonicallyIncreasingClock()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62175





--- Comment #14 from Devdatta <pwjd73 at motorola.com>  2011-08-01 15:38:20 PST ---
(In reply to comment #4)
> (From update of attachment 101659 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101659&action=review
> 
> This looks sane to me.
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * wtf/CurrentTime.cpp:
> > +        (WTF::monotonicallyIncreasingTime):
> 
> Please fill in this ChangeLog, explaining how the existing implementation of monotonicallyIncreasingTime can fail.

Please find the explanation in the attached patch.

> 
> > Source/JavaScriptCore/wtf/CurrentTime.cpp:313
> > +#elif PLATFORM(GTK)
> 
> I think it would be better to use #if ENABLE(GLIB_SUPPORT) here.
g_get_monotonic_time is supported in glib since version 2.28. I am getting compilation errors on QT when I use this API. So, implementing this under PLATFORM(GTK) instead of ENABLE(GLIB_SUPPORT).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.